> On Oct. 22, 2014, 10:31 p.m., Andreas Hansson wrote: > > src/mem/ruby/system/RubyPort.cc, line 323 > > <http://reviews.gem5.org/r/2466/diff/1/?file=42342#file42342line323> > > > > Why has this changed?
Because I want the system's copy to be the actual copy and ruby's copy to be secondary. On Oct. 22, 2014, 10:31 p.m., Nilay Vaish wrote: > > I do not understand what the patch is doing, and why we do not rely on > > doing things as before with the System being responsible for the memories > > and the backing stores. This memory does not even have to be connected to > > anything in the physical sense. > > > > Could you provide some background as to the code, and why the code that is > > there at the moment does not fit the bill? Andreas, I think Joel has answered your question in sufficient detail. I would add some more information for you. Remember that Ruby currently in the repo has a copy of the memory, different from the system's copy (system's copy is not allocated in SE mode). I have not been able to convince people that we should work with a single copy of the memory. With this patch, the copy of the memory would be explicitly visible in the configuration. And with the later patch that changes memory controller's interface, we would move towards the system's copy being the actual copy of memory (in the mainline repo), and ruby's copy only for the purpose Joel describes. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2466/#review5424 ----------------------------------------------------------- On Oct. 21, 2014, 10:01 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2466/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 10:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10497:587c77ab8adc > --------------------------- > ruby: provide a second copy of the memory > This memory is required in some cases. It can be enabled by invoking > the option --access-phys-mem > > > Diffs > ----- > > configs/ruby/Ruby.py ffe6ab7141ab > src/mem/ruby/system/DMASequencer.hh ffe6ab7141ab > src/mem/ruby/system/DMASequencer.cc ffe6ab7141ab > src/mem/ruby/system/RubyPort.hh ffe6ab7141ab > src/mem/ruby/system/RubyPort.cc ffe6ab7141ab > src/mem/ruby/system/RubySystem.py ffe6ab7141ab > src/mem/ruby/system/Sequencer.py ffe6ab7141ab > src/mem/ruby/system/System.hh ffe6ab7141ab > src/mem/ruby/system/System.cc ffe6ab7141ab > > Diff: http://reviews.gem5.org/r/2466/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
