----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2466/#review5424 -----------------------------------------------------------
src/mem/ruby/system/RubyPort.cc <http://reviews.gem5.org/r/2466/#comment4905> Why has this changed? src/mem/ruby/system/RubyPort.cc <http://reviews.gem5.org/r/2466/#comment4906> The flow control here seems strange, first turn it into a response, then pass it to the memory? src/mem/ruby/system/RubySystem.py <http://reviews.gem5.org/r/2466/#comment4907> Why is this needed when the system already keeps track of all memory? I do not understand what the patch is doing, and why we do not rely on doing things as before with the System being responsible for the memories and the backing stores. This memory does not even have to be connected to anything in the physical sense. Could you provide some background as to the code, and why the code that is there at the moment does not fit the bill? - Andreas Hansson On Oct. 21, 2014, 10:01 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2466/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 10:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10497:587c77ab8adc > --------------------------- > ruby: provide a second copy of the memory > This memory is required in some cases. It can be enabled by invoking > the option --access-phys-mem > > > Diffs > ----- > > configs/ruby/Ruby.py ffe6ab7141ab > src/mem/ruby/system/DMASequencer.hh ffe6ab7141ab > src/mem/ruby/system/DMASequencer.cc ffe6ab7141ab > src/mem/ruby/system/RubyPort.hh ffe6ab7141ab > src/mem/ruby/system/RubyPort.cc ffe6ab7141ab > src/mem/ruby/system/RubySystem.py ffe6ab7141ab > src/mem/ruby/system/Sequencer.py ffe6ab7141ab > src/mem/ruby/system/System.hh ffe6ab7141ab > src/mem/ruby/system/System.cc ffe6ab7141ab > > Diff: http://reviews.gem5.org/r/2466/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
