----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2497/#review5502 -----------------------------------------------------------
src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2497/#comment4951> Why do we need the allocate() call? Since we know what the request is, can we not perform the allocation in the constructor itself? - Nilay Vaish On Nov. 17, 2014, 6:15 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2497/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10547:e8cae196bce7 > --------------------------- > mem: Make the requests carried by packets const > > This adds a basic level of sanity checking to the packet by ensuring > that a request is not modified once the packet is created. The only > issue that had to be worked around is the relaying of > software-prefetches in the cache. The specific situation is now solved > by first copying the request, and then creating a new packet > accordingly. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2497/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
