----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2497/#review5576 -----------------------------------------------------------
src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2497/#comment4996> Is one vs. two spaces after periods in the gem5 style guide? :) src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/2497/#comment4997> This part seems kind of ad hoc... why is it that src/dest need to be copied but nothing else? I believe it's true, it just seems arbitrary with nothing else to go on here. Also seems like we should have confidence that the packet is created cleanly (the last 4 asserts seem like overkill). - Steve Reinhardt On Nov. 16, 2014, 10:15 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2497/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2014, 10:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10547:e8cae196bce7 > --------------------------- > mem: Make the requests carried by packets const > > This adds a basic level of sanity checking to the packet by ensuring > that a request is not modified once the packet is created. The only > issue that had to be worked around is the relaying of > software-prefetches in the cache. The specific situation is now solved > by first copying the request, and then creating a new packet > accordingly. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2497/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
