> On Nov. 29, 2014, 9:12 p.m., Steve Reinhardt wrote: > > src/mem/cache/cache_impl.hh, line 627 > > <http://reviews.gem5.org/r/2497/diff/1/?file=42564#file42564line627> > > > > This part seems kind of ad hoc... why is it that src/dest need to be > > copied but nothing else? I believe it's true, it just seems arbitrary with > > nothing else to go on here. > > > > Also seems like we should have confidence that the packet is created > > cleanly (the last 4 asserts seem like overkill).
Remnants of my debugging. I've removed it and bumped the patch. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2497/#review5576 ----------------------------------------------------------- On Nov. 30, 2014, 9:19 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2497/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2014, 9:19 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10570:c19d57302758 > --------------------------- > mem: Make the requests carried by packets const > > This adds a basic level of sanity checking to the packet by ensuring > that a request is not modified once the packet is created. The only > issue that had to be worked around is the relaying of > software-prefetches in the cache. The specific situation is now solved > by first copying the request, and then creating a new packet > accordingly. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh dd04eb06ad42 > src/mem/packet.hh dd04eb06ad42 > > Diff: http://reviews.gem5.org/r/2497/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
