----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2501/#review5522 -----------------------------------------------------------
Ship it! I don't think "out in" is correct usage. - Nilay Vaish On Nov. 17, 2014, 6:18 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2501/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10551:74b409fc3dd6 > --------------------------- > cpu: Move the packet deallocations out in the O3 CPU > > Move the packet deallocations out in the O3 CPU so that the completeDataAccess > deals only with the LSQ specific parts and the generic recvTimingResp frees > the > packet. > > > Diffs > ----- > > src/cpu/o3/lsq_impl.hh 1a9e235cab09 > src/cpu/o3/lsq_unit_impl.hh 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2501/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
