----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5529 -----------------------------------------------------------
Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well. Is that accurate? In isolation, this seems reasonable, but it doesn't seem like enough of an advantage to justify bumping our minimum supported version. - Steve Reinhardt On Nov. 23, 2014, 3:03 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2527/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 3:03 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10564:b90448378de5 > --------------------------- > config: ruby: Get rid of an "eval" and an "exec" operating on generated code. > > We can get the same result using importlib. > > > Diffs > ----- > > configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2527/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
