Hi all, I strongly suggest to not go beyond 2.6 at the moment. All Ubuntu 12.04 machines and RHE6 machines have 2.6 as their default, and that matches with our previous assumptions also regarding gcc etc.
I agree with Steve that we can consider a move to 2.7, but it should be for stronger reasons that saving a few lines of code. I suggest we revert the change for now. Andreas ________________________________________ From: gem5-dev [gem5-dev-boun...@gem5.org] On Behalf Of Steve Reinhardt via gem5-dev [gem5-dev@gem5.org] Sent: Sunday, November 23, 2014 7:37 PM To: Steve Reinhardt; Default; Gabe Black Subject: Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an "eval" and an "exec" operating on generated code. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5529 ----------------------------------------------------------- Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well. Is that accurate? In isolation, this seems reasonable, but it doesn't seem like enough of an advantage to justify bumping our minimum supported version. - Steve Reinhardt On Nov. 23, 2014, 3:03 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2527/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 3:03 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10564:b90448378de5 > --------------------------- > config: ruby: Get rid of an "eval" and an "exec" operating on generated code. > > We can get the same result using importlib. > > > Diffs > ----- > > configs/ruby/Ruby.py 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2527/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
