----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2503/#review5538 -----------------------------------------------------------
Ship it! I don't know what are we trying to achieve by interfacing gem5 and SystemC. But the patch seems fine to me. util/systemc/sc_gem5_control.hh <http://reviews.gem5.org/r/2503/#comment4968> What is this version for? util/systemc/sc_gem5_control.hh <http://reviews.gem5.org/r/2503/#comment4967> Can you elaborate on what an elaboration is? I am guessing it to be a SystemC term. util/systemc/sc_gem5_control.cc <http://reviews.gem5.org/r/2503/#comment4966> I am not against this indentation, but I think the norm is to align the arguments vertically. - Nilay Vaish On Nov. 17, 2014, 6:18 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2503/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10554:f6e35a3dcc8f > --------------------------- > config: SystemC Gem5Control top level additions > > This patch cleans up a few style issues and adds a few capabilities to the > SystemC top level 'Gem5Control/Gem5System' mechanism. These include: > > 1) A space to store/retrieve a version string for a model > 2) A mechanism for registering functions to be called at the end of > elaboration to perform simulation setup tasks in SystemC > 3) Adding setGDBRemotePort to the Gem5Control > 4) Changing the sc_set_time_resolution behaviour to instead check that > the SystemC time resolution is already acceptable > > > Diffs > ----- > > util/systemc/sc_gem5_control.hh 1a9e235cab09 > util/systemc/sc_gem5_control.cc 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2503/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
