----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5591 -----------------------------------------------------------
I do not see much value though, but I am fine with patch. configs/common/FSConfig.py <http://reviews.gem5.org/r/2524/#comment5005> Should we make this function a part of SysConfig class? - Nilay Vaish On Nov. 23, 2014, 7:26 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2524/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 7:26 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10561:b2a85a0c0571 > --------------------------- > config: Add two options for setting the kernel command line. > > Both options accept template which will, through python string formatting, > have "mem", "disk", and "script" values substituted in from the mdesc. > Additional values can be used on a case by case basis by passing them as > keyword arguments to the fillInCmdLine function. That makes it possible to > have specialized parameters for a particular ISA, for instance. > > The first option lets you specify the template directly, and the other lets > you specify a file which has the template in it. > > > Diffs > ----- > > configs/common/FSConfig.py 6317351a288c0349c5855c7431bc1eeade61605c > configs/common/Options.py 6317351a288c0349c5855c7431bc1eeade61605c > configs/example/fs.py 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2524/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
