> On Nov. 30, 2014, 6:38 p.m., Nilay Vaish wrote: > > I do not see much value though, but I am fine with patch.
The ChromeOS kernel needs lots of command line arguments, both to configure the kernel and to leave information for the system at large. This is so we don't have to have a custom hack on top of the config scripts to jam those in there. I would really, really like to see the config stuff modularized way more than it is now, so that it's realistic to create a different config script which reuses the checked in code instead of having to modify it in place. > On Nov. 30, 2014, 6:38 p.m., Nilay Vaish wrote: > > configs/common/FSConfig.py, line 58 > > <http://reviews.gem5.org/r/2524/diff/1/?file=42724#file42724line58> > > > > Should we make this function a part of SysConfig class? I can see why you'd say that, but I don't think so right now. It's true that it primarily applies values from the SysConfig class, but that was mostly a coincidence of how things are implemented. If we want to add a new parameter which comes from somewhere else, it would be odd to pass that to a function on the SysConfig. If you were to say that that parameter should be in SysConfig in that case, I'd believe that argument. But I'm still just on the other side of the fence. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5591 ----------------------------------------------------------- On Nov. 23, 2014, 7:26 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2524/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 7:26 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10561:b2a85a0c0571 > --------------------------- > config: Add two options for setting the kernel command line. > > Both options accept template which will, through python string formatting, > have "mem", "disk", and "script" values substituted in from the mdesc. > Additional values can be used on a case by case basis by passing them as > keyword arguments to the fillInCmdLine function. That makes it possible to > have specialized parameters for a particular ISA, for instance. > > The first option lets you specify the template directly, and the other lets > you specify a file which has the template in it. > > > Diffs > ----- > > configs/common/FSConfig.py 6317351a288c0349c5855c7431bc1eeade61605c > configs/common/Options.py 6317351a288c0349c5855c7431bc1eeade61605c > configs/example/fs.py 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2524/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
