> On Nov. 29, 2014, 10:18 a.m., Andreas Hansson wrote:
> >
> 
> Andreas Hansson wrote:
>     One more thought, do you need to serialise and unserialise the offset? If 
> not, why not?

Offset for mc146818 events are already serialized, but they were posted 
immediately during unserialize. This change postpones event scheduling.


- Cagdas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2545/#review5565
-----------------------------------------------------------


On Dec. 4, 2014, 6:21 p.m., Cagdas Dirik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2545/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 6:21 p.m.)
> 
> 
> Review request for Default, Andrew Bardsley, Andreas Hansson, and Ali Saidi.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> This change includes edits to MC146818 timer to prevent RTC events firing 
> before startup to comply with SimObject initialization call sequence.
> 
> 
> Diffs
> -----
> 
>   src/dev/mc146818.hh fea29fc045ee 
>   src/dev/mc146818.cc fea29fc045ee 
>   src/dev/x86/cmos.hh fea29fc045ee 
>   src/dev/x86/cmos.cc fea29fc045ee 
> 
> Diff: http://reviews.gem5.org/r/2545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cagdas Dirik
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to