----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2545/#review5643 -----------------------------------------------------------
Ship it! Looks good. What about the regressions? - Andreas Hansson On Dec. 4, 2014, 6:21 p.m., Cagdas Dirik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2545/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:21 p.m.) > > > Review request for Default, Andrew Bardsley, Andreas Hansson, and Ali Saidi. > > > Repository: gem5 > > > Description > ------- > > This change includes edits to MC146818 timer to prevent RTC events firing > before startup to comply with SimObject initialization call sequence. > > > Diffs > ----- > > src/dev/mc146818.hh fea29fc045ee > src/dev/mc146818.cc fea29fc045ee > src/dev/x86/cmos.hh fea29fc045ee > src/dev/x86/cmos.cc fea29fc045ee > > Diff: http://reviews.gem5.org/r/2545/diff/ > > > Testing > ------- > > > Thanks, > > Cagdas Dirik > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
