> On Dec. 5, 2014, 11:47 a.m., Andreas Hansson wrote:
> > Looks good. What about the regressions?
> 
> Cagdas Dirik wrote:
>     I have run hello world in se mode for both X86 and ARM. I also have a 
> small program that does int array manipulation, and I run it in se mode for 
> both X86 and ARM. I typically run timing and detailed cpu with simple memory. 
> I have also run this same small program in FS mode on X86.
>     
>     If there are more regression tests, could you please let me know? Since I 
> am new here, I am figuring out as I go.
> 
> Andreas Hansson wrote:
>     It seems this changeset causes the ALPHA tsunami-minor/o3 regressions to 
> fail (for example 
> build/ALPHA/tests/opt/long/fs/10.linux-boot/alpha/linux/tsunami-minor). I 
> have not yet narrowed down the root cause, so perhaps you could have a look 
> Cagdas?

dev/alpha/tsunami_io needs to override startup and call rtc.startup()

it's probably worth also removing the inclusion of mc146818.hh in 
dev/arm/rtc_pl031.cc


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2545/#review5643
-----------------------------------------------------------


On Dec. 4, 2014, 6:21 p.m., Cagdas Dirik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2545/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 6:21 p.m.)
> 
> 
> Review request for Default, Andrew Bardsley, Andreas Hansson, and Ali Saidi.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> This change includes edits to MC146818 timer to prevent RTC events firing 
> before startup to comply with SimObject initialization call sequence.
> 
> 
> Diffs
> -----
> 
>   src/dev/mc146818.hh fea29fc045ee 
>   src/dev/mc146818.cc fea29fc045ee 
>   src/dev/x86/cmos.hh fea29fc045ee 
>   src/dev/x86/cmos.cc fea29fc045ee 
> 
> Diff: http://reviews.gem5.org/r/2545/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cagdas Dirik
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to