----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5693 -----------------------------------------------------------
src/dev/Cirrus.py <http://reviews.gem5.org/r/2511/#comment5067> Remove? Or add a comment src/dev/cirrus.hh <http://reviews.gem5.org/r/2511/#comment5068> all of these public? Why? src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5069> Please use getConstPtr src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5070> Remove? Or add a more elaborate comment src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5071> Can we not simply check if kvmkvm is nullptr? src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5072> I am not too fond of this. Can we note make it null or have a NullKVMVM or similar? src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5073> Rather unfortunate imho. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5074> What if we have a scheduled updateEvent? - Andreas Hansson On Dec. 17, 2014, 7:39 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2511/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 7:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10609:07584c650657 > --------------------------- > dev: cirrus: Add a simplified device model for the cirrus graphics device. > > All control register accesses are dropped on the floor. If used with KVM, the > frame buffer is set up as a memory like region to keep performance from > tanking. If a VNC server is configured, the buffer is marked dirty once every > simulated 100ms. > > > Diffs > ----- > > src/dev/Cirrus.py PRE-CREATION > src/dev/SConscript a0cb57e1c072965dcdd51465beff37b264b41424 > src/dev/cirrus.hh PRE-CREATION > src/dev/cirrus.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2511/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
