----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5696 -----------------------------------------------------------
src/dev/Cirrus.py <http://reviews.gem5.org/r/2511/#comment5087> Remove, I think. src/dev/cirrus.hh <http://reviews.gem5.org/r/2511/#comment5086> They probably shouldn't be. I'll fix that. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5088> Ok. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5085> I don't know what's going on here. This device model was originally written by someone else, and I added a small fix patch on top of it recently. I'll need to look into what this is for. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5084> Since USE_KVM is constant at compile time, this if will get compiled away if it's false. We could check kvmVM only, but it would be slightly less efficient. That's probably ok, though. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5081> Unfortunately no. We can't have the kvmVM parameter in the SimObject if KVM isn't available because we won't have access to that type. In that case, p->kvmVM won't compile. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5082> It's const everywhere else, we just need to un-constify it here so we can set it up initially. src/dev/cirrus.cc <http://reviews.gem5.org/r/2511/#comment5083> Yeah, we should deschedule that. - Gabe Black On Dec. 17, 2014, 7:39 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2511/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 7:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10609:07584c650657 > --------------------------- > dev: cirrus: Add a simplified device model for the cirrus graphics device. > > All control register accesses are dropped on the floor. If used with KVM, the > frame buffer is set up as a memory like region to keep performance from > tanking. If a VNC server is configured, the buffer is marked dirty once every > simulated 100ms. > > > Diffs > ----- > > src/dev/Cirrus.py PRE-CREATION > src/dev/SConscript a0cb57e1c072965dcdd51465beff37b264b41424 > src/dev/cirrus.hh PRE-CREATION > src/dev/cirrus.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2511/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
