> On Dec. 23, 2014, 10:25 a.m., Andreas Hansson wrote: > > Looks fine. Could you mark the issues that are fixed as fixed (or dropped > > for that matter)? > > > > Thanks. > > > > I am still not sure if I like the USE_KVM better, or perhaps having a > > NullKvm object.
Yeah. There was one other mistake I noticed which I'm fixing. I'm not going to push this until I get back into the office after New Years and can actually test it. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5708 ----------------------------------------------------------- On Dec. 23, 2014, 1:04 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2511/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 1:04 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10608:7c8363f44c5b > --------------------------- > dev: cirrus: Add a simplified device model for the cirrus graphics device. > > All control register accesses are dropped on the floor. If used with KVM, the > frame buffer is set up as a memory like region to keep performance from > tanking. If a VNC server is configured, the buffer is marked dirty once every > simulated 100ms. > > > Diffs > ----- > > src/dev/Cirrus.py PRE-CREATION > src/dev/SConscript b3ea7444f46666f020332d1c6fe8635aa81f719a > src/dev/cirrus.hh PRE-CREATION > src/dev/cirrus.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2511/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
