----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2741/#review6065 -----------------------------------------------------------
Thanks a lot for the changes. I have a few other minor comments and then I think it's good to go. src/arch/arm/freebsd/system.cc (line 79) <http://reviews.gem5.org/r/2741/#comment5268> I'm guessing that FreeBSD doesn't have these? This code is used to not cache certain structures that will be cacheable on one cpu, but uncachebale on another during boot. I think it's probably fine to retrun false here and be done with it (along with deleting the member variables). src/arch/arm/freebsd/system.cc (line 110) <http://reviews.gem5.org/r/2741/#comment5269> Does FreeBSD use a flattened devicetree for hardware identification or something else? If it doesn't then this could can be removed. src/arch/generic/freebsd/threadinfo.hh (line 174) <http://reviews.gem5.org/r/2741/#comment5270> is this called the same as it is in linux? (for all the functions above). This code isn't needed and it can all just panic() with unimplmented if there isn't a good corallary in FreeBSD - Ali Saidi On April 23, 2015, 3:26 p.m., Ruslan Bukin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2741/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 3:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This adds support for FreeBSD/aarch64 FS and SE mode (basic set of syscalls > only) > > > Diffs > ----- > > src/sim/process.cc 74e3c7359393 > src/kern/freebsd/events.hh PRE-CREATION > src/kern/freebsd/events.cc PRE-CREATION > src/kern/freebsd/freebsd.hh PRE-CREATION > src/dev/terminal.cc 74e3c7359393 > src/kern/SConscript 74e3c7359393 > src/base/vnc/vncserver.cc 74e3c7359393 > src/dev/arm/gic_pl390.cc 74e3c7359393 > src/arch/generic/freebsd/threadinfo.hh PRE-CREATION > src/base/loader/elf_object.cc 74e3c7359393 > src/base/loader/object_file.hh 74e3c7359393 > src/base/output.cc 74e3c7359393 > src/arch/arm/system.hh 74e3c7359393 > src/arch/arm/system.cc 74e3c7359393 > src/arch/arm/process.cc 74e3c7359393 > src/arch/arm/linux/system.cc 74e3c7359393 > src/arch/arm/freebsd/system.hh PRE-CREATION > src/arch/arm/freebsd/system.cc PRE-CREATION > src/arch/arm/linux/system.hh 74e3c7359393 > src/arch/arm/SConscript 74e3c7359393 > src/arch/arm/freebsd/freebsd.hh PRE-CREATION > src/arch/arm/freebsd/freebsd.cc PRE-CREATION > src/arch/arm/freebsd/process.hh PRE-CREATION > src/arch/arm/freebsd/process.cc PRE-CREATION > src/arch/arm/ArmSystem.py 74e3c7359393 > > Diff: http://reviews.gem5.org/r/2741/diff/ > > > Testing > ------- > > Tested on FreeBSD/amd64 host simulating FreeBSD/aarch64 (FS, SE) and > Linux/aarch64 (FS) > > > Thanks, > > Ruslan Bukin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
