----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2741/#review6069 -----------------------------------------------------------
Some minor bits. For the rest it looks great. Thanks for the contribution! src/arch/arm/freebsd/freebsd.hh (line 9) <http://reviews.gem5.org/r/2741/#comment5278> Should we stick to the "normal" format, or is there a good reason to keep this as is? src/arch/arm/freebsd/process.hh (line 31) <http://reviews.gem5.org/r/2741/#comment5279> I guess these should technically be __ARCH_ARM... src/arch/arm/freebsd/system.cc (line 103) <http://reviews.gem5.org/r/2741/#comment5280> whitespace src/arch/arm/process.cc (line 210) <http://reviews.gem5.org/r/2741/#comment5275> I guess there is no way or merging the "if linux" blocks? src/arch/arm/system.hh (line 282) <http://reviews.gem5.org/r/2741/#comment5277> virtual src/arch/arm/system.cc (line 254) <http://reviews.gem5.org/r/2741/#comment5276> I'd even suggest to leave these in the header for now and make them one-liners. , - Andreas Hansson On April 24, 2015, 10:45 a.m., Ruslan Bukin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2741/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 10:45 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This adds support for FreeBSD/aarch64 FS and SE mode (basic set of syscalls > only) > > > Diffs > ----- > > src/arch/arm/freebsd/process.cc PRE-CREATION > src/arch/arm/freebsd/system.hh PRE-CREATION > src/arch/arm/freebsd/system.cc PRE-CREATION > src/arch/arm/linux/system.hh 74e3c7359393 > src/arch/arm/linux/system.cc 74e3c7359393 > src/arch/arm/process.cc 74e3c7359393 > src/arch/arm/system.hh 74e3c7359393 > src/arch/arm/system.cc 74e3c7359393 > src/arch/generic/freebsd/threadinfo.hh PRE-CREATION > src/base/loader/elf_object.cc 74e3c7359393 > src/base/loader/object_file.hh 74e3c7359393 > src/base/output.cc 74e3c7359393 > src/base/vnc/vncserver.cc 74e3c7359393 > src/dev/arm/gic_pl390.cc 74e3c7359393 > src/dev/terminal.cc 74e3c7359393 > src/kern/SConscript 74e3c7359393 > src/kern/freebsd/events.hh PRE-CREATION > src/kern/freebsd/events.cc PRE-CREATION > src/kern/freebsd/freebsd.hh PRE-CREATION > src/sim/process.cc 74e3c7359393 > src/arch/arm/freebsd/process.hh PRE-CREATION > src/arch/arm/ArmSystem.py 74e3c7359393 > src/arch/arm/SConscript 74e3c7359393 > src/arch/arm/freebsd/freebsd.hh PRE-CREATION > src/arch/arm/freebsd/freebsd.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2741/diff/ > > > Testing > ------- > > Tested on FreeBSD/amd64 host simulating FreeBSD/aarch64 (FS, SE) and > Linux/aarch64 (FS) > > > Thanks, > > Ruslan Bukin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
