> On April 24, 2015, 10:54 a.m., Andreas Hansson wrote: > > src/arch/arm/freebsd/freebsd.hh, line 9 > > <http://reviews.gem5.org/r/2741/diff/9/?file=44708#file44708line9> > > > > Should we stick to the "normal" format, or is there a good reason to > > keep this as is? > > Ruslan Bukin wrote: > what the normal format is ? we use this format for all the external stuff > related to The FreeBSD Project (we have a bunch of license headers for > different languages, different sponsors, but the format is the same) > > Andreas Hansson wrote: > All files in the gem5 src/ tree should have the same license text you > find in the LICENSE file in the root. Note that there is an extra paragraph > in the files with an ARM copyright. > > The text should be exactly the same as what you have, it's merely the > formatting that differs. I have no objection to either, I am merely > suggesting to keep it the same to avoid confusion. > > Ruslan Bukin wrote: > should I keep 3rd clause as LICENSE file has, or can it be removed ? > > Andreas Hansson wrote: > 3rd? There is the first copyright block, and then two paragraphs. > > Ruslan Bukin wrote: > 3rd BSD clause: > neither the name of the copyright holders nor the names of its > contributors may be used to endorse or promote products derived from > this software without specific prior written permission. > > we (in Computer Laboratory) prefer 2-clause BSD license
Ah, I see. I think we should stick to the same license throughout. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2741/#review6069 ----------------------------------------------------------- On April 24, 2015, 12:46 p.m., Ruslan Bukin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2741/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 12:46 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This adds support for FreeBSD/aarch64 FS and SE mode (basic set of syscalls > only) > > > Diffs > ----- > > src/arch/arm/ArmSystem.py 74e3c7359393 > src/arch/arm/SConscript 74e3c7359393 > src/arch/arm/freebsd/freebsd.hh PRE-CREATION > src/arch/arm/freebsd/freebsd.cc PRE-CREATION > src/arch/arm/freebsd/process.hh PRE-CREATION > src/arch/arm/freebsd/process.cc PRE-CREATION > src/arch/arm/freebsd/system.hh PRE-CREATION > src/arch/arm/freebsd/system.cc PRE-CREATION > src/arch/arm/linux/system.hh 74e3c7359393 > src/arch/arm/linux/system.cc 74e3c7359393 > src/arch/arm/process.cc 74e3c7359393 > src/arch/arm/system.hh 74e3c7359393 > src/arch/arm/system.cc 74e3c7359393 > src/arch/generic/freebsd/threadinfo.hh PRE-CREATION > src/base/loader/elf_object.cc 74e3c7359393 > src/base/loader/object_file.hh 74e3c7359393 > src/base/output.cc 74e3c7359393 > src/base/vnc/vncserver.cc 74e3c7359393 > src/dev/arm/gic_pl390.cc 74e3c7359393 > src/dev/terminal.cc 74e3c7359393 > src/kern/SConscript 74e3c7359393 > src/kern/freebsd/events.hh PRE-CREATION > src/kern/freebsd/events.cc PRE-CREATION > src/kern/freebsd/freebsd.hh PRE-CREATION > src/sim/process.cc 74e3c7359393 > > Diff: http://reviews.gem5.org/r/2741/diff/ > > > Testing > ------- > > Tested on FreeBSD/amd64 host simulating FreeBSD/aarch64 (FS, SE) and > Linux/aarch64 (FS) > > > Thanks, > > Ruslan Bukin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
