----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2821/#review6155 -----------------------------------------------------------
Will support be added to the caches? Can you perhaps provide some more hints in the patch description. At the moment it seems we are just bloating the packet. src/mem/packet.hh (line 15) <http://reviews.gem5.org/r/2821/#comment5344> 2010, 2015 I suppose? Or has this been ongoing for five years? src/mem/packet.cc (line 15) <http://reviews.gem5.org/r/2821/#comment5345> 2010, 2013? How does it match with the 2015 in the request? src/mem/request.hh (line 15) <http://reviews.gem5.org/r/2821/#comment5346> Same as above src/mem/request.hh (line 89) <http://reviews.gem5.org/r/2821/#comment5347> I do not understand this change. It seems we have enough flag bits to spare, do we not? - Andreas Hansson On May 11, 2015, 10:20 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2821/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10861:298a4aa9acf0 > --------------------------- > mem: add request types for acquire and release > > Add support for acquire and release requests. These synchronization > operations > are commonly supported by several modern instruction sets. > > > Diffs > ----- > > src/mem/packet.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/packet.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/protocol/RubySlicc_Exports.sm > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/request.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2821/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
