> On May 11, 2015, 10:52 p.m., Andreas Hansson wrote:
> > Will support be added to the caches? Can you perhaps provide some more 
> > hints in the patch description. At the moment it seems we are just bloating 
> > the packet.

Not to the caches, but we will be releasing a Ruby protocol - along with the 
release of our APU model - that makes use of these fields.


> On May 11, 2015, 10:52 p.m., Andreas Hansson wrote:
> > src/mem/request.hh, line 89
> > <http://reviews.gem5.org/r/2821/diff/1/?file=45116#file45116line89>
> >
> >     I do not understand this change. It seems we have enough flag bits to 
> > spare, do we not?

By my count we have 27 bits used, we're adding 2, so that leaves 3 so it can't 
hurt.


- Tony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2821/#review6155
-----------------------------------------------------------


On May 11, 2015, 3:20 p.m., Tony Gutierrez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2821/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 3:20 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10861:298a4aa9acf0
> ---------------------------
> mem: add request types for acquire and release
> 
> Add support for acquire and release requests.  These synchronization 
> operations
> are commonly supported by several modern instruction sets.
> 
> 
> Diffs
> -----
> 
>   src/mem/packet.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec 
>   src/mem/packet.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec 
>   src/mem/protocol/RubySlicc_Exports.sm 
> fbdaa08aaa426b9f4660c366f934ccb670d954ec 
>   src/mem/request.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec 
> 
> Diff: http://reviews.gem5.org/r/2821/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tony Gutierrez
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to