> On June 1, 2015, 12:47 p.m., Stephan Diestelhorst wrote: > > I am also curious, how these will be used both inside the memory subsystem > > and at the interface layer. Right now.. the duplication between flags and > > request types seems somewhat erm.. duplicate :)
Thanks for reviewing our patch. Responses are below. > On June 1, 2015, 12:47 p.m., Stephan Diestelhorst wrote: > > src/mem/request.hh, line 145 > > <http://reviews.gem5.org/r/2821/diff/2/?file=45483#file45483line145> > > > > Why do we have new request types *and* new flags? To me, you'd do only > > either? So only mark loads with acquire and stores with release, no? Our patch is similar to some of the duplication that occurs with other request types (e.g., swapreq/swapresp, and corresponding flags). More importantly, it might actually make sense to tag a request as both acquire and release (e.g., an RMW tagged memory_order_seq_cst). > On June 1, 2015, 12:47 p.m., Stephan Diestelhorst wrote: > > src/mem/request.hh, line 638 > > <http://reviews.gem5.org/r/2821/diff/2/?file=45483#file45483line638> > > > > Boolean OR of the flags could be faster. I don't follow exactly what you're asking for. Also, I don't think that this specific boolean expression has any impact on simulation performance. - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2821/#review6441 ----------------------------------------------------------- On May 26, 2015, 8:01 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2821/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 8:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10833:46fbb145d215 > --------------------------- > mem: add request types for acquire and release > > Add support for acquire and release requests. These synchronization > operations > are commonly supported by several modern instruction sets. > > > Diffs > ----- > > src/mem/packet.hh df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/packet.cc df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/protocol/RubySlicc_Exports.sm > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/request.hh df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2821/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
