> On May 12, 2015, 3:55 p.m., Nilay Vaish wrote: > > You need to provide example of what this change is trying to achieve. > > Personally, if wanted buffers to have a size, I would want to that size > > to be configurable in python.
Would it be helpful if we described an example in the patch description? This is obviously an improvement in functionality that people may want to use. I agree that eventually we would want to do this in Python. I'll let Mark comment on that. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2814/#review6176 ----------------------------------------------------------- On May 11, 2015, 10:21 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2814/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10871:e121f9b1023e > --------------------------- > ruby: Changes to support finite buffering in ruby. > > Adds code in controller generating python code to initialize message buffers > with a size specified in the SLICC definition of of the controller's buffer. > This allows all message buffers including mandatory queues to use finite > buffering. > > Additionally adds code to properly check the resource constraints for an > action with respect to the entries available in a controller's network buffers > in the case that multiple buffers are defined to map to the same virtual > network. Previously this case would cause multiple resource checks to see if > a single entry was available, rather than one check to see if multiple entries > were available. > > > Diffs > ----- > > src/mem/slicc/ast/OutPortDeclAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/symbols/StateMachine.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2814/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
