On Tue, 12 May 2015, Mark Wilkening wrote:
On May 12, 2015, 3:55 p.m., Nilay Vaish wrote:
You need to provide example of what this change is trying to achieve.
Personally, if wanted buffers to have a size, I would want to that size
to be configurable in python.
Brad Beckmann wrote:
Would it be helpful if we described an example in the patch description?
This is obviously an improvement in functionality that people may want to use.
I agree that eventually we would want to do this in Python. I'll let Mark
comment on that.
This change allows precise controll of specific individual buffer sizes
in a controller. Because these buffers are specific to a particular
coherence protocol (dependant on your gem5 build), it seems appropriate
to set these sizes in the SLICC file. This also does not have to be
used, if not used the default sizes for these buffers will be used
instead. In the future we could potentially set the sizes in python by
setting sizes for buffers identified by virtual network ID and network
direction (in/out). This will require tight coordination with the
protocol definition to be used properly however.
With this patch you can just set the size in SLICC like follows:
MessageBuffer mandatoryQueue, ordered="false", buffer_size=32
MessageBuffer protocolSpecificQueue, network="out", virtual_network=4,
buffer_size=64
You need to explain why the language requires a new keyword. Define the
init function of the associated controller (which is a sim object and
hence will have the init() called on it) and set the buffer size over
there.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
