----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2963/#review6791 -----------------------------------------------------------
src/mem/cache/blk.hh (line 113) <http://reviews.gem5.org/r/2963/#comment5866> Incidentally, I posted a patch yesterday which adds set and way info to a cache block in ruby. src/mem/cache/tags/base_set_assoc.hh (line 260) <http://reviews.gem5.org/r/2963/#comment5867> Why not run this loop to allocAssoc? Is blks[i]->way != i? src/mem/cache/tags/base_set_assoc.cc (line 135) <http://reviews.gem5.org/r/2963/#comment5868> Same comment as above. Why not maintain blks[i]->way = i? src/mem/cache/tags/fa_lru.cc (line 234) <http://reviews.gem5.org/r/2963/#comment5869> assert(set == 0); - Nilay Vaish On July 13, 2015, 4:26 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2963/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 4:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10926:cc4c7cdc060b > --------------------------- > mem: Make caches way aware > > This patch makes cache sets aware of the way number. This enables > some nice features such as the ablity to restrict way allocation. The > implemented mechanism allows to set a maximum way number to be > allocated 'k' which must fulfill 0 < k <= N (where N is the number of > ways). In the future more sophisticated mechasims can be implemented. > > > Diffs > ----- > > src/mem/cache/tags/lru.cc 5ee72f4b2931 > src/mem/cache/tags/random_repl.cc 5ee72f4b2931 > src/mem/cache/tags/base.hh 5ee72f4b2931 > src/mem/cache/tags/base_set_assoc.hh 5ee72f4b2931 > src/mem/cache/tags/base_set_assoc.cc 5ee72f4b2931 > src/mem/cache/tags/fa_lru.hh 5ee72f4b2931 > src/mem/cache/tags/fa_lru.cc 5ee72f4b2931 > src/mem/cache/blk.hh 5ee72f4b2931 > src/mem/cache/cache_impl.hh 5ee72f4b2931 > > Diff: http://reviews.gem5.org/r/2963/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
