----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2963/#review6858 -----------------------------------------------------------
Ship it! Other than a few minor things it looks good. src/mem/cache/cache_impl.hh (line 1586) <http://reviews.gem5.org/r/2963/#comment5922> Aren't we using nullptr now? src/mem/cache/tags/base.hh (line 211) <http://reviews.gem5.org/r/2963/#comment5923> This and the next function seem to violate style rules with regard to curly braces. src/mem/cache/tags/base_set_assoc.hh (line 327) <http://reviews.gem5.org/r/2963/#comment5924> Curly braces for this function and the next should be on a new line. - Tony Gutierrez On July 28, 2015, 3:15 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2963/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 3:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10940:837cdbf13ea3 > --------------------------- > mem: Make caches way aware > > This patch makes cache sets aware of the way number. This enables > some nice features such as the ablity to restrict way allocation. The > implemented mechanism allows to set a maximum way number to be > allocated 'k' which must fulfill 0 < k <= N (where N is the number of > ways). In the future more sophisticated mechasims can be implemented. > > > Diffs > ----- > > src/mem/cache/blk.hh acd48ddd725f > src/mem/cache/tags/lru.cc acd48ddd725f > src/mem/cache/tags/random_repl.cc acd48ddd725f > src/mem/cache/tags/fa_lru.hh acd48ddd725f > src/mem/cache/tags/fa_lru.cc acd48ddd725f > src/mem/cache/tags/base.hh acd48ddd725f > src/mem/cache/tags/base_set_assoc.hh acd48ddd725f > src/mem/cache/tags/base_set_assoc.cc acd48ddd725f > src/mem/cache/cache_impl.hh acd48ddd725f > > Diff: http://reviews.gem5.org/r/2963/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
