----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3028/#review7197 -----------------------------------------------------------
src/mem/request.hh (lines 308 - 310) <http://reviews.gem5.org/r/3028/#comment6097> Seems like the only way to set this variable is through the constructor. Why not mark as const? - Nilay Vaish On Aug. 11, 2015, 9:05 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3028/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 9:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds the instruction sequence number to the request and provides a > request constructor that accepts a sequence number for initialization. > > > Diffs > ----- > > src/mem/request.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > > Diff: http://reviews.gem5.org/r/3028/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
