> On Sept. 16, 2015, 4:39 p.m., Nilay Vaish wrote: > > src/mem/request.hh, lines 309-311 > > <http://reviews.gem5.org/r/3028/diff/1/?file=48960#file48960line309> > > > > Seems like the only way to set this variable is through the > > constructor. Why not mark as const?
In http://reviews.gem5.org/r/3090/ I added optionally tracing virtual address which meant calling another Request constructor. That also meant I needed to set the inst. sequence number using a setter. A bit unfortunate but don't think it's worth changing the Request constructor or other methods. - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3028/#review7197 ----------------------------------------------------------- On Aug. 11, 2015, 9:05 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3028/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 9:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds the instruction sequence number to the request and provides a > request constructor that accepts a sequence number for initialization. > > > Diffs > ----- > > src/mem/request.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > > Diff: http://reviews.gem5.org/r/3028/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
