----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review7382 -----------------------------------------------------------
Overall the patch seems fine to me. Just take care of the concern mentioned below. util/systemc/stats.cc (line 79) <http://reviews.gem5.org/r/3132/#comment6233> The file name can be kept as constant, but at least pass an argument to this function that specifies the file path. I would prefer if you use the same output directory that the rest of the system is using. - Nilay Vaish On Oct. 16, 2015, 1:46 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3132/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 1:46 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > In previous versions of systemC-gem5 coupling statistics were not updated for > the systemc-gem5 simulation. systemC-gem5 simulation only need the previously > built config.ini file and normal gem5 simulation has to be run once to > generate config.ini file. Thus stats.txt inside the m5out folder is redundant > for systemC-gem5 simulation. A new stats file is now generated with the all > the statistics for systemC-gem5 simulation. This will also resolve the stats > issue in tlm-sysmtemC simulation. > > > Diffs > ----- > > util/systemc/stats.hh UNKNOWN > util/systemc/stats.cc UNKNOWN > util/tlm/main.cc UNKNOWN > util/systemc/main.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/3132/diff/ > > > Testing > ------- > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
