> On Oct. 17, 2015, 2 a.m., Nilay Vaish wrote: > > src/base/loader/object_file.cc, lines 154-156 > > <http://reviews.gem5.org/r/3131/diff/1/?file=49899#file49899line154> > > > > Make these lines common to both if and else.
The problem is the cleanup: the gzip library uses libc's file handling so I need to fclose for the gzip'd file but regular close() for the typical case. - Curtis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3131/#review7383 ----------------------------------------------------------- On Nov. 14, 2015, 12:01 a.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3131/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 12:01 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Automatically detect and decompress gzip'd content in the object loader. > > > Diffs > ----- > > src/base/loader/object_file.cc 2375b33bddc61ea484b3bd194ba02f7889095624 > > Diff: http://reviews.gem5.org/r/3131/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
