----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3131/#review7586 -----------------------------------------------------------
src/base/loader/object_file.cc (line 144) <http://reviews.gem5.org/r/3131/#comment6517> Does mmap complain with nullptr? src/base/loader/object_file.cc (lines 165 - 175) <http://reviews.gem5.org/r/3131/#comment6520> I still think this code should be common to both cases. Your function doGzipLoad() should return the fd to the tmp file you create. src/base/loader/object_file.cc (line 176) <http://reviews.gem5.org/r/3131/#comment6518> Does this check fail if doGzipLoad() returns nullptr? - Nilay Vaish On Nov. 14, 2015, 12:01 a.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3131/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 12:01 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Automatically detect and decompress gzip'd content in the object loader. > > > Diffs > ----- > > src/base/loader/object_file.cc 2375b33bddc61ea484b3bd194ba02f7889095624 > > Diff: http://reviews.gem5.org/r/3131/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
