----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3178/#review7460 -----------------------------------------------------------
Can you please provide a clearer patch title and description? To me, it is unclear how this is a 'cleaner' solution. I understand that this fixes some issues testing multiple sequencers, but I don't understand where the retries, and port inst vs. data designation changes fit in all this. - Joel Hestness On Oct. 30, 2015, 9:49 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3178/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:49 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11184:1160e90d0f03 > --------------------------- > ruby: cleaner ruby tester support > > This patch allows the ruby random tester to use ruby ports that may only > support instr or data requests. This patch is similar to a previous changeset > (8932:1b2c17565ac8) that was unfortunately broken by subsequent changesets. > This current patch implements the support in a more straight-forward way. > The patch also includes better DPRINTFs and generalizes the retry behavior > needed by the ruby tester so that other testers/cpu models can use it as well. > > > Diffs > ----- > > configs/example/ruby_random_test.py > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MESI_Three_Level.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MESI_Two_Level.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MI_example.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MOESI_CMP_directory.py > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MOESI_CMP_token.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MOESI_hammer.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/Check.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/CheckTable.cc > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/RubyTester.hh > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/RubyTester.cc > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/RubyTester.py > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/system/RubyPort.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/system/RubyPort.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/system/Sequencer.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3178/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
