> On Dec. 8, 2015, 3:05 p.m., Joel Hestness wrote: > > This is ok with me, but can you please fix the parameter spacing in the > > config files?
Thanks. Will fix throughout these file before shipping. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3178/#review7713 ----------------------------------------------------------- On Dec. 8, 2015, 1:31 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3178/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 1:31 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11257:d055c013fcaf > --------------------------- > ruby: more flexible ruby tester support > > This patch allows the ruby random tester to use ruby ports that may only > support instr or data requests. This patch is similar to a previous changeset > (8932:1b2c17565ac8) that was unfortunately broken by subsequent changesets. > This current patch implements the support in a more straight-forward way. > Since retries are now tested when running the ruby random tester, this patch > splits up the retry and drain check behavior so that RubyPort children, such > as the GPUCoalescer, can perform those operations correctly without having to > duplicate code. Finally, the patch also includes better DPRINTFs for > debugging the tester. > > > Diffs > ----- > > configs/ruby/MOESI_hammer.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/cpu/testers/rubytest/Check.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/cpu/testers/rubytest/CheckTable.cc > c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/cpu/testers/rubytest/RubyTester.hh > c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/cpu/testers/rubytest/RubyTester.cc > c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/cpu/testers/rubytest/RubyTester.py > c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/mem/ruby/system/RubyPort.hh c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/mem/ruby/system/RubyPort.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/mem/ruby/system/Sequencer.cc c0ea80fed78fef29ad2829b9d93e7bd568c46665 > src/mem/ruby/system/Sequencer.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > configs/ruby/MI_example.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > configs/ruby/MOESI_CMP_directory.py > c0ea80fed78fef29ad2829b9d93e7bd568c46665 > configs/ruby/MOESI_CMP_token.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > configs/ruby/MESI_Three_Level.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > configs/ruby/MESI_Two_Level.py c0ea80fed78fef29ad2829b9d93e7bd568c46665 > configs/example/ruby_random_test.py > c0ea80fed78fef29ad2829b9d93e7bd568c46665 > > Diff: http://reviews.gem5.org/r/3178/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
