> On Nov. 2, 2015, 5:18 p.m., Jason Lowe-Power wrote: > > configs/ruby/MESI_Three_Level.py, line 104 > > <http://reviews.gem5.org/r/3178/diff/1/?file=50937#file50937line104> > > > > I hate to be picky, but could you use this code instead: > > > > if len(system.cpu) == 1: > > clk_domain = system.cpu[0].clk_domain > > else: > > clk_domain = system.cpu[i].clk_domain > > > > ... > > clk_domain=clk_domain > > > > This significantly reduces the amount of changed code, and makes it > > more readable.
Thank you for the suggestion. We have made this change and we will post our new patch soon. > On Nov. 2, 2015, 5:18 p.m., Jason Lowe-Power wrote: > > src/mem/ruby/system/RubyPort.cc, line 289 > > <http://reviews.gem5.org/r/3178/diff/1/?file=50949#file50949line289> > > > > Why did this move from ruby_hit_callback? I don't have a good reason > > for this not to move, but it seems that it potentially should be in another > > patch. Thank you for the question. The function was moved because testDrainComplete should only be called when the entire response is complete. With the prior location, the GPUCoalescer would call it after every individual packet response. The first version of this patch moved it to the request path, which was an error. I think that was due to a merge error after having to maintain this patch for 4+ years. The new version of this patch will move it to the correct location. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3178/#review7431 ----------------------------------------------------------- On Oct. 30, 2015, 9:49 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3178/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:49 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11184:1160e90d0f03 > --------------------------- > ruby: cleaner ruby tester support > > This patch allows the ruby random tester to use ruby ports that may only > support instr or data requests. This patch is similar to a previous changeset > (8932:1b2c17565ac8) that was unfortunately broken by subsequent changesets. > This current patch implements the support in a more straight-forward way. > The patch also includes better DPRINTFs and generalizes the retry behavior > needed by the ruby tester so that other testers/cpu models can use it as well. > > > Diffs > ----- > > configs/example/ruby_random_test.py > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MESI_Three_Level.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MESI_Two_Level.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MI_example.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MOESI_CMP_directory.py > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MOESI_CMP_token.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > configs/ruby/MOESI_hammer.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/Check.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/CheckTable.cc > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/RubyTester.hh > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/RubyTester.cc > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/cpu/testers/rubytest/RubyTester.py > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/system/RubyPort.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/system/RubyPort.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/system/Sequencer.py 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3178/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
