> On May 7, 2015, 7:55 a.m., Andreas Hansson wrote: > > src/mem/cache/cache_impl.hh, line 639 > > <http://reviews.gem5.org/r/2691/diff/3/?file=44871#file44871line639> > > > > Is it safe to call this here and ignore the return value? > > > > It would be nice if we do not assume that the response is always > > accepted. > > > > Perhaps schedule an event and put it in a queue rather? > > Steve Reinhardt wrote: > recvTimingResp() doesn't have a return value... responses are always > accepted.
Actually responses are not always accepted directly. They are always guarnateed to be sunk without dependencies, but there are modules that use flow control on responses (simply for rate regulation reasons). - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2691/#review6124 ----------------------------------------------------------- On May 6, 2015, 10:59 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2691/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:59 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10745:9b84d1b570e3 > --------------------------- > mem: implement x86 locked accesses in timing-mode classic cache > > Add LockedRMW(Read|Write)(Req|Resp) commands. In timing mode, > use a combination of clearing permission bits and leaving > an MSHR in place to prevent accesses & snoops from touching > a locked block between the read and write parts of an locked > RMW sequence. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/cache/mshr.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/packet.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/packet.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2691/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
