> On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 529 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52019#file52019line529> > > > > This is not a very nice way to design things... > > > > It would be much better if this module was event based. Is there a > > reason why it is not?
I couldn't think of any better implementation. We should retry sending packets when some of them cannot make it through the fabric (due to contention). We periodically try to drain packets from input ports if there is any packet in any of the input ports. This implementation is very similar to what we have for i8254xGBe device model. > On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.hh, line 70 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52018#file52018line70> > > > > A few of these methods should probably be const. Also, some comments > > would be great. Fixed > On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.hh, line 181 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52018#file52018line181> > > > > unordered_map? I changed it to unordered_map. > On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.hh, line 185 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52018#file52018line185> > > > > a pointer to a std::vector? It's not a pointer to std::vector anymore. > On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 51 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52019#file52019line51> > > > > there is a count associated with the vector port, why not use that? Done. - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7843 ----------------------------------------------------------- On Jan. 11, 2016, 5:47 a.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3230/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 5:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11292:b148c394be6d > --------------------------- > dist,dev: add an ethernet switch model > > > Diffs > ----- > > src/dev/net/etherswitch.cc PRE-CREATION > src/dev/net/Ethernet.py 9d2364203316 > src/dev/net/SConscript 9d2364203316 > src/dev/net/etherswitch.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/3230/diff/ > > > Testing > ------- > > several testing done with different benchmarks and different switch sizes > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
