> On Jan. 8, 2016, 5:29 p.m., Tony Gutierrez wrote: > > src/dev/Ethernet.py, line 88 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52016#file52016line88> > > > > Does 1Gbps as the default make sense? I think that is a little dated, > > particularly in the case of the systems multi/pd gem5 is meant to model. > > 10Gbps would probably be a more reasonable default.
I changed it to 10Gbps. > On Jan. 8, 2016, 5:29 p.m., Tony Gutierrez wrote: > > src/dev/etherswitch.cc, line 73 > > <http://reviews.gem5.org/r/3230/diff/1/?file=52019#file52019line73> > > > > Use nullptr throughout Fixed throughout. - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/#review7842 ----------------------------------------------------------- On Jan. 11, 2016, 5:47 a.m., Mohammad Alian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3230/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 5:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11292:b148c394be6d > --------------------------- > dist,dev: add an ethernet switch model > > > Diffs > ----- > > src/dev/net/etherswitch.cc PRE-CREATION > src/dev/net/Ethernet.py 9d2364203316 > src/dev/net/SConscript 9d2364203316 > src/dev/net/etherswitch.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/3230/diff/ > > > Testing > ------- > > several testing done with different benchmarks and different switch sizes > > > Thanks, > > Mohammad Alian > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
