----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3373/#review8309 -----------------------------------------------------------
Thanks for getting these out! However, there are a few low-level issues, and some funky wiring that goes on here. configs/common/HMC.py (line 107) <http://reviews.gem5.org/r/3373/#comment7158> present configs/common/HMC.py (line 111) <http://reviews.gem5.org/r/3373/#comment7159> covers configs/common/HMC.py (line 113) <http://reviews.gem5.org/r/3373/#comment7160> access complete configs/common/HMC.py (line 129) <http://reviews.gem5.org/r/3373/#comment7161> What is the significance of "modified" here? configs/common/HMC.py (line 198) <http://reviews.gem5.org/r/3373/#comment7162> spurious space configs/common/HMC.py (line 204) <http://reviews.gem5.org/r/3373/#comment7163> What is the unit here? configs/common/HMC.py (line 241) <http://reviews.gem5.org/r/3373/#comment7164> spaces around operators. configs/common/HMC.py (line 242) <http://reviews.gem5.org/r/3373/#comment7165> are these three cases not the same? configs/common/HMC.py (line 349) <http://reviews.gem5.org/r/3373/#comment7174> I am not sure I understand the special case, here. configs/common/HMC.py (line 360) <http://reviews.gem5.org/r/3373/#comment7175> merge these two configs/common/HMC.py (line 368) <http://reviews.gem5.org/r/3373/#comment7176> loop and lists of buffers? configs/common/HMC.py (line 454) <http://reviews.gem5.org/r/3373/#comment7177> who wires up things if arch == 1? Please also add the arch descriptions inthe comments. src/mem/SerialLink.py (line 64) <http://reviews.gem5.org/r/3373/#comment7178> unit? src/mem/serial_link.hh (line 315) <http://reviews.gem5.org/r/3373/#comment7179> unit? src/mem/serial_link.cc (line 217) <http://reviews.gem5.org/r/3373/#comment7180> where do you actually increase the packet size? A - Stephan Diestelhorst On May 18, 2016, 7:34 a.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3373/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 7:34 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > In this new hmc configuration we have used the existing components in gem5 > mainly [SerialLink] [NoncoherentXbar]& [DRAMCtrl] to define 3 different > architecture for HMC. > =========== > Highlights > =========== > 1- It explores 3 different HMC architectures > 2- It creates 4-HMC crossbars and attaches 16 vault controllers with it. This > will connect vaults to serial links > 3- From the previous version, HMCController with round robin funtionality is > being removed and all the serial links are being accessible directly from > user ports > 4- Latency incorporated by HMCController (in previous version) is being added > to SerialLink > > > Diffs > ----- > > configs/common/HMC.py UNKNOWN > configs/common/MemConfig.py UNKNOWN > src/mem/SerialLink.py UNKNOWN > src/mem/serial_link.hh UNKNOWN > src/mem/serial_link.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/3373/diff/ > > > Testing > ------- > > Current version only works for traffic generator setup {can be extended for > full-system and system-emulation} > =============== > How to run it > =============== > from you gem5 home directory run the following commands > > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=0 > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=1 > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=2 > > Dependency > =========== > This patch required another tester patch to be applied before running the > test > > http://reviews.gem5.org/r/3374/ > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
