----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3373/#review8422 -----------------------------------------------------------
Hi Abdul, The code is now more compact after your recent updates and additional comments help. A few style and readability issues still remain, but getting there. Radhika configs/common/HMC.py (lines 207 - 208) <http://reviews.gem5.org/r/3373/#comment7288> Is this param used? configs/common/HMC.py (line 232) <http://reviews.gem5.org/r/3373/#comment7291> Purely for readability, how about xbar_buffer_size_* instead of cross_buffer_size_*? configs/common/HMC.py (line 362) <http://reviews.gem5.org/r/3373/#comment7289> space around operator configs/common/HMC.py (lines 372 - 373) <http://reviews.gem5.org/r/3373/#comment7290> Here and elsewhere in the changed lines: space around operators (, = == etc.) Also, 0 is the default start for the range function. configs/common/HMC.py (line 374) <http://reviews.gem5.org/r/3373/#comment7293> Pass meaning 'do nothing' instead of None meaning 'no object'. You could do if i != j instead of placing the work in the else clause? configs/common/HMC.py (lines 383 - 386) <http://reviews.gem5.org/r/3373/#comment7292> Can these two params be set during instantiation of the Bridge objects, and only set the ranges inside this loop? But do retain the comment currently there for the None statement. - Radhika Jagtap On June 19, 2016, 10:34 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3373/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 10:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > In this new hmc configuration we have used the existing components in gem5 > mainly [SerialLink] [NoncoherentXbar]& [DRAMCtrl] to define 3 different > architecture for HMC. > =========== > Highlights > =========== > 1- It explores 3 different HMC architectures > 2- It creates 4-HMC crossbars and attaches 16 vault controllers with it. This > will connect vaults to serial links > 3- From the previous version, HMCController with round robin funtionality is > being removed and all the serial links are being accessible directly from > user ports > 4- Latency incorporated by HMCController (in previous version) is being added > to SerialLink > > > Diffs > ----- > > src/mem/SerialLink.py UNKNOWN > src/mem/serial_link.hh UNKNOWN > src/mem/serial_link.cc UNKNOWN > configs/common/HMC.py UNKNOWN > configs/common/MemConfig.py UNKNOWN > > Diff: http://reviews.gem5.org/r/3373/diff/ > > > Testing > ------- > > Current version only works for traffic generator setup {can be extended for > full-system and system-emulation} > =============== > How to run it > =============== > from you gem5 home directory run the following commands > > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=0 > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=1 > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=2 > > Dependency > =========== > This patch required another tester patch to be applied before running the > test > > http://reviews.gem5.org/r/3374/ > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
