> On June 20, 2016, 10:47 a.m., Radhika Jagtap wrote: > > configs/common/HMC.py, line 406 > > <http://reviews.gem5.org/r/3373/diff/5/?file=56288#file56288line406> > > > > space around operator > > Abdul Mutaal Ahmad wrote: > on every operator ? * or + etc ?
As per coding guidlines: http://www.m5sim.org/Coding_Style one space around binary operators (+, -, <, >, etc.) including assignment operators (=, +=, etc.) - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3373/#review8422 ----------------------------------------------------------- On June 19, 2016, 10:34 p.m., Abdul Mutaal Ahmad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3373/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 10:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > In this new hmc configuration we have used the existing components in gem5 > mainly [SerialLink] [NoncoherentXbar]& [DRAMCtrl] to define 3 different > architecture for HMC. > =========== > Highlights > =========== > 1- It explores 3 different HMC architectures > 2- It creates 4-HMC crossbars and attaches 16 vault controllers with it. This > will connect vaults to serial links > 3- From the previous version, HMCController with round robin funtionality is > being removed and all the serial links are being accessible directly from > user ports > 4- Latency incorporated by HMCController (in previous version) is being added > to SerialLink > > > Diffs > ----- > > src/mem/SerialLink.py UNKNOWN > src/mem/serial_link.hh UNKNOWN > src/mem/serial_link.cc UNKNOWN > configs/common/HMC.py UNKNOWN > configs/common/MemConfig.py UNKNOWN > > Diff: http://reviews.gem5.org/r/3373/diff/ > > > Testing > ------- > > Current version only works for traffic generator setup {can be extended for > full-system and system-emulation} > =============== > How to run it > =============== > from you gem5 home directory run the following commands > > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=0 > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=1 > build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 > --mode=RANDOM --arch=2 > > Dependency > =========== > This patch required another tester patch to be applied before running the > test > > http://reviews.gem5.org/r/3374/ > > > Thanks, > > Abdul Mutaal Ahmad > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
