----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3483/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11498:7a8fef12086e --------------------------- arm: Correctly check FP/SIMD access permission in aarch32 The current implementation of aarch32 FP/SIMD in gem5 assumes that EL1 and higher are all 32-bit. This breaks interprocessing since an aarch64 EL1 uses different enable/disable bits. This change updates the permission checks to according to what is prescribed by the ARM ARM. Change-Id: Icdcef31b00644cfeebec00216b3993aa1de12b88 Signed-off-by: Andreas Sandberg <[email protected]> Reviewed-by: Mitch Hayenga <[email protected]> Reviewed-by: Nathanael Premillieu <[email protected]> Diffs ----- src/arch/arm/insts/static_inst.hh 1f04f97c014d src/arch/arm/insts/static_inst.cc 1f04f97c014d src/arch/arm/isa/insts/fp.isa 1f04f97c014d src/arch/arm/isa/templates/neon.isa 1f04f97c014d src/arch/arm/isa/templates/vfp.isa 1f04f97c014d src/arch/arm/utility.hh 1f04f97c014d src/arch/arm/utility.cc 1f04f97c014d Diff: http://reviews.gem5.org/r/3483/diff/ Testing ------- Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
