----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3487/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11502:d3ab28442a8e --------------------------- arm: Rewrite ERET to behave according to the ARMv8 ARM The ERET instruction doesn't set PSTATE correctly in some cases (particularly when returning to aarch32 code). Among other things, this breaks EL0 thumb code when using a 64-bit kernel. This changeset updates the ERET implementation to match the ARM ARM. Change-Id: I408e7c69a23cce437859313dfe84e68744b07c98 Signed-off-by: Andreas Sandberg <[email protected]> Reviewed-by: Nathanael Premillieu <[email protected]> Diffs ----- src/arch/arm/insts/static_inst.hh 1f04f97c014d src/arch/arm/insts/static_inst.cc 1f04f97c014d src/arch/arm/isa/insts/branch64.isa 1f04f97c014d src/arch/arm/isa/operands.isa 1f04f97c014d src/arch/arm/miscregs.hh 1f04f97c014d src/arch/arm/utility.hh 1f04f97c014d Diff: http://reviews.gem5.org/r/3487/diff/ Testing ------- Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
