----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3756/#review9285 -----------------------------------------------------------
Does converting this to a class have any impact on performance? src/cpu/base_dyn_inst.hh (line 169) <http://reviews.gem5.org/r/3756/#comment7932> Why is this now a deque? Seems like you still only push_back and pop_front. - Jason Lowe-Power On Jan. 16, 2017, 11:52 a.m., Rekai Gonzalez Alberquilla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3756/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 11:52 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11761:e62eb2fb62b4 > --------------------------- > cpu: Result refactoring > > The Result union used to collect the result of an instruction is now a > class of its own, with its constructor, and explicit casting methods for > cleanliness. > > This is also a stepping stone to have vector registers, and instructions > that produce a vector register as output. > > Change-Id: I6f40c11cb5e835d8b11f7804a4e967aff18025b9 > Reviewed-by: Andreas Sandberg <[email protected]> > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh 78ef8daecd81 > src/cpu/checker/cpu.hh 78ef8daecd81 > src/cpu/checker/cpu_impl.hh 78ef8daecd81 > src/cpu/inst_res.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/3756/diff/ > > > Testing > ------- > > Builtin regressions > > > Thanks, > > Rekai Gonzalez Alberquilla > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
