Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/17989
to review the following change.
Change subject: arch-arm: Expose haveGicv3CPUInterface to the ISA interface
......................................................................
arch-arm: Expose haveGicv3CPUInterface to the ISA interface
Change-Id: I36232b7618ad875983f34b741c51f12ddb9ae166
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/arch/arm/isa.cc
M src/arch/arm/isa.hh
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/arch/arm/isa.cc b/src/arch/arm/isa.cc
index 42e1cba..f166fe7 100644
--- a/src/arch/arm/isa.cc
+++ b/src/arch/arm/isa.cc
@@ -65,7 +65,8 @@
_vecRegRenameMode(Enums::Full),
pmu(p->pmu),
haveGICv3CPUInterface(false),
- impdefAsNop(p->impdef_nop)
+ impdefAsNop(p->impdef_nop),
+ afterStartup(false)
{
miscRegs[MISCREG_SCTLR_RST] = 0;
@@ -406,6 +407,8 @@
gicv3CpuInterface->setThreadContext(tc);
}
}
+
+ afterStartup = true;
}
diff --git a/src/arch/arm/isa.hh b/src/arch/arm/isa.hh
index 1931306..b4689d7 100644
--- a/src/arch/arm/isa.hh
+++ b/src/arch/arm/isa.hh
@@ -105,6 +105,8 @@
*/
bool impdefAsNop;
+ bool afterStartup;
+
/** MiscReg metadata **/
struct MiscRegLUTEntry {
uint32_t lower; // Lower half mapped to this register
@@ -706,6 +708,16 @@
Enums::DecoderFlavour decoderFlavour() const { return
_decoderFlavour; }
+ /** Getter for haveGICv3CPUInterface */
+ bool haveGICv3CpuIfc() const
+ {
+ // haveGICv3CPUInterface is initialized at startup time, hence
+ // trying to read its value before the startup stage will lead
+ // to an error
+ assert(afterStartup);
+ return haveGICv3CPUInterface;
+ }
+
Enums::VecRegRenameMode
vecRegRenameMode() const
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17989
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I36232b7618ad875983f34b741c51f12ddb9ae166
Gerrit-Change-Number: 17989
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
