Hello Boris, On 04/02/21 12:43 am, Boris Shingarov wrote: >> I think I had come across that problem too but I am sure >> that one of my patches will fix that. Probably this one > > Yes -- that's what I meant by "commits related to 3dd04381". > So, let's start with this small area. >
Sure. >> Yes, I can submit it via gerrit. >> As a kernel developer, I am more used to mailing list based reviews >> but feel free to let me know what works best for you. > > Gerrit is the procedure currently used by the gem5 community. Even though I > personally find it non-ideal, it is kind of a given for the foreseeable > future, and I think the optimal scenario (within the realistic choices) would > be if you started upstreaming using that procedure. The other alternative, > of which I was afraid before I initially wrote to you, would have been if you > had abandoned the project or had no time/energy to do the rebasing / pushing > / working with the review, in that case I was thinking about just taking your > patches and putting them on Gerrit myself but I can see a whole number of > reasons to avoid this. > > Sure, I'll submit the changes via Gerrit. Aside from rebasing on top of the develop branch, I think it will be easier for us if I bring all the 32-bit cleanups and fixes to the beginning of the series and then introduce 64-bit mode followed by new instructions. The current sequence breaks 32-bit support in the beginning and then restores it back towards the end. Wondering if that could be a problem with the CI? - Sandipan _______________________________________________ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
