Hello Gabe, On 08/02/21 10:58 am, Gabe Black wrote: > Thanks, I took a very quick pass through them, primarily looking for places > touched outside of the arch/power directory (where the impact is larger). > The only two things I saw were where you added an #if THE_ISA in the CPU > (not ok, has to be handled differently), and adding some constants and > checks to the object file class (looked pretty reasonable). The bulk of the > changes are contained in arch/power which is great, since that should mean > the constraints on how things are done should be reduced. I don't know the > Power ISA at all, but I'll look at the changes from a generic gem5/ISA > implementation perspective and give some feedback for the first few patches > at some point in the near future. >
Thanks for going over them. I do agree with your comments on the first patch and can wait until ZeroReg usage gets cleaned up across ISAs. Looking forward to your inputs. - Sandipan _______________________________________________ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
