Out of curiosity, what is the reasoning behind removing the comparison? It seems that being more explicit isn't a bad thing.
On Thu, Mar 18, 2010 at 5:47 PM, nathan binkert <[email protected]> wrote: >> diff --git a/src/mem/ruby/system/DMASequencer.cc >> b/src/mem/ruby/system/DMASequencer.cc >> --- a/src/mem/ruby/system/DMASequencer.cc >> +++ b/src/mem/ruby/system/DMASequencer.cc >> @@ -96,7 +96,7 @@ >> len : >> RubySystem::getBlockSizeBytes() - offset; >> >> - if (write) { >> + if (write && (data != NULL)) { > > I have to agree with Steve that this should be (write && data), but > I'm just givin you a hard time you > > >> + if (active_request.data != NULL) { > and again > >> + if (active_request.data != NULL) { > and again > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
