On Thu, Mar 18, 2010 at 5:33 PM, nathan binkert <[email protected]> wrote: >>> And just as an aside, we really need to get rid of these functions >>> that just test a flag and make it easy to test the flags directly. >> >> I'm not so sure I agree... these accessors hide the fact that we're >> packing all these flags into a single Flags variable (and that we're >> using the Flags type at all). Having them there in the first place >> made it easier to ditch the manual bitfield and move to Flags in the >> first place. Also they hide the ugly all-caps bit position constants. > > True, it did make it easier, but the goal of the Flags class is to > make it so there is only one way to do flags.
Until we invent an even better way... > I did expose them in the Request object and it seems to have worked > out (though there are still some isFoo functions that I never got rid > of.). Just because I haven't complained doesn't mean I like it :-) Steve _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
