Ali Saidi wrote: > > > On Tue, 23 Nov 2010 11:52:22 -0800, nathan binkert <n...@binkert.org> > wrote: >> Looks good to me. I don't see the problem with the print function >> either. (Ali, it's for an IP, not the netmask). I can nitpick (and >> this is bikeshedding), but I'm not sure that I agree that inheritance >> (as opposed to containment) from IPAddress is the right thing to do >> (on the C++ side). > Look at what the code is doing to get the values? left shifting and > converting to a byte? It's going to print all 0s. > > Ali > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev
Oh yeah, you're right, those shifts look like they're going the wrong way. I'll fix that. Gabe _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
